Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alpine to 3.9 #2

Merged
merged 1 commit into from Jun 16, 2019

Conversation

Projects
None yet
2 participants
@jlelse
Copy link
Contributor

commented Jun 10, 2019

No description provided.

@djmaze djmaze merged commit 8e2b9d8 into djmaze:master Jun 16, 2019

1 check passed

continuous-integration/drone/pr Build is passing
Details
@djmaze

This comment has been minimized.

Copy link
Owner

commented Jun 16, 2019

Thanks.

@jlelse

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

Your CI seems to be broken 🤔 Pushing the template doesn't seem to work.

@jlelse

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

And a question: Would you accept a PR adding a feature for pre-backup commands? I modified the code to be able to execute docker commands prior to backup, so I can do a database dump etc. It works perfectly, but adds the docker-cli package to the image and one needs to mount the docker socket for the use of this feature.

@djmaze

This comment has been minimized.

Copy link
Owner

commented Jun 17, 2019

Your CI seems to be broken

Well, it is configured to just build git tags, because I am tagging commits according to the restic version they install. Not sure if a different versioning might make more sense..

@djmaze

This comment has been minimized.

Copy link
Owner

commented Jun 17, 2019

And a question: Would you accept a PR adding a feature for pre-backup commands?

Not sure I like to extend the container's privileges that much. Personally, I am thinking about disabling the built-in cron and using swarm-cronjob for scheduling instead. Then, for pre-backup purposes, you could schedule a different service with enough time buffer so it is finished when the backup service is scheduled.

From a separation of concerns standpoint, that would be the cleaner approach. Of course, that only works in swarm mode. Would that be feasible for you?

@jlelse

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

@djmaze I'm using docker-compose (without swarm), so removing the built-in cron would mean I would need to create my own docker file.

Regarding the Docker-CLI thing, I will create a PR and we can discuss things further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.