New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for private registry authentication #10

Merged
merged 3 commits into from Apr 9, 2018

Conversation

Projects
None yet
3 participants
@ledermann
Copy link
Contributor

ledermann commented Mar 23, 2018

This PR includes a change by @pdeveltere and a README enhancement by me. It allows using shepherd for private registries.

Tested with Docker 18.03.0-ce. Closes #6

@matteocng

This comment has been minimized.

Copy link

matteocng commented Apr 8, 2018

Thanks for this. Successfully tested on Swarm - Docker version 18.03.0-ce, build 0520e24, compose-file version 3.6.

@djmaze
Copy link
Owner

djmaze left a comment

Nice, LGTM.

(Sorry for the late reaction.)

shepherd Outdated
echo "Sleeping $sleep_time before next update"
sleep "$sleep_time"
done


This comment has been minimized.

@djmaze

djmaze Apr 8, 2018

Owner

Please remove these empty lines

This comment has been minimized.

@ledermann

ledermann Apr 9, 2018

Contributor

Done

@djmaze

djmaze approved these changes Apr 9, 2018

@djmaze

This comment has been minimized.

Copy link
Owner

djmaze commented Apr 9, 2018

Thanks for the contribution!

@djmaze djmaze merged commit 781b554 into djmaze:master Apr 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment