Stack Overflow when loading files #67

Closed
ncreep opened this Issue Oct 2, 2011 · 1 comment

Comments

Projects
None yet
2 participants
@ncreep
Contributor

ncreep commented Oct 2, 2011

I get a StackOverflowError when loading either spending.xml or discogs_20110201_labels.xml from the test/resources folder.

The following line in the Text case class seems to be the culprit:

if (CharRegex.unapplySeq(text).isEmpty) 
    throw new IllegalArgumentException("Illegal character in text '" + text + "'")

Couldn't figure out what character breaks it.

@djspiewak

This comment has been minimized.

Show comment
Hide comment
@djspiewak

djspiewak Oct 2, 2011

Owner

I can repeat the issue with discogs_20110201_labels.xml, but not with spending.xml. I've optimized the regular expression and landed the fix.

Owner

djspiewak commented Oct 2, 2011

I can repeat the issue with discogs_20110201_labels.xml, but not with spending.xml. I've optimized the regular expression and landed the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment