This repository has been archived by the owner on May 15, 2019. It is now read-only.
Zipper.slice returns incorrect result if Zipper contains equal elements #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zipper#slice
andDeepZipper#slice
currently assume that no two elements are equal, which isn't always true. This pull request fixes the problem by creating aZipper.flatMapWithIndex
and basingslice
off of that. Conveniently,DeepZipper
already had such a method and only required a small change toslice
.Note that the
take
,drop
, andsplitAt
methods all useslice
internally and exhibit the same behavior.