Improved performance of preconditions on strings #73

Merged
merged 1 commit into from Oct 23, 2011

Conversation

Projects
None yet
3 participants
@mkneissl
Contributor

mkneissl commented Oct 21, 2011

Replaced !regex.unapplySeq.isEmpty by regex.pattern.matcher(_).matches.

This avoids a lot of allocations of unneeded objects and improves the
overall performance on Android by a factor of 2-3 (for my use case).

Improved performance of preconditions on strings.
Replaced !regex.unapplySeq.isEmpty by regex.pattern.matcher(_).matches.

This avoids a lot of allocations of unneeded objects and improves the 
overall performance on Android by a factor of 2-3 (for my use case).
@josharnold52

This comment has been minimized.

Show comment
Hide comment
@josharnold52

josharnold52 Oct 21, 2011

Contributor

Nice! Even on my notebook, this improves the times of the "load" performance tests by at least 20%.

Contributor

josharnold52 commented Oct 21, 2011

Nice! Even on my notebook, this improves the times of the "load" performance tests by at least 20%.

@djspiewak djspiewak merged commit d9975e4 into djspiewak:master Oct 23, 2011

@djspiewak

This comment has been minimized.

Show comment
Hide comment
@djspiewak

djspiewak Oct 23, 2011

Owner

Awesome! Merged.

Owner

djspiewak commented Oct 23, 2011

Awesome! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment