Rewrote several light routines. #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hope....
SimLV
reviewed
Jul 15, 2021
This reverts commit 68fbcd3.
SimLV
requested changes
Dec 24, 2021
src/light_data.c
Outdated
| lgt->flags &= ~2; | ||
| if ( lgt->flags & LgtF_Dynamic ) | ||
| { | ||
| lgt->field_9[0] = a2; |
There was a problem hiding this comment.
Could you please break field_9 (as array of size 5) into field_9 and field_A[4].
Also I am unsure is field_9 signed or not (a2 is signed).
Also a2 is either byte or signed char.
src/light_data.c
Outdated
| if ( lgt->flags & LgtF_Dynamic ) | ||
| { | ||
| lgt->field_9[0] = a2; | ||
| *(unsigned short *)&lgt->field_1C[8] = a3; |
There was a problem hiding this comment.
same.
byte field_1C[10]; should be split into byte field_1C[8]; plus unsigned short field_24;
and here should be lgt->field_24 = a3;
Loobinex
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.