New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit. #1

Merged
merged 5 commits into from Oct 8, 2017

Conversation

Projects
None yet
2 participants
@dkorolev
Owner

dkorolev commented Oct 8, 2017

Hi @sompylasar, could you take a look? :-) Thanks!

@sompylasar

It should work like this, but...

@@ -1,2 +1,46 @@
# curlable
A simple wrapper to turn [stateless] command-line utilities into HTTP endpoints.

This comment has been minimized.

@sompylasar

sompylasar Oct 8, 2017

Collaborator

"stateless" looks like a malformed Markdown link.

@sompylasar

sompylasar Oct 8, 2017

Collaborator

"stateless" looks like a malformed Markdown link.

This comment has been minimized.

@dkorolev

dkorolev Oct 8, 2017

Owner

Except it's not.

@dkorolev

dkorolev Oct 8, 2017

Owner

Except it's not.

Show outdated Hide outdated README.md
Show outdated Hide outdated README.md
The supported command line parameters are:
1. `-c`: The external command to `curl`-ify, defaults to `bc -l`.

This comment has been minimized.

@sompylasar

sompylasar Oct 8, 2017

Collaborator

The default command makes no sense, better remove it (add explicit to the example).

@sompylasar

sompylasar Oct 8, 2017

Collaborator

The default command makes no sense, better remove it (add explicit to the example).

This comment has been minimized.

@dkorolev

dkorolev Oct 8, 2017

Owner

Why does it make no sense? It's just to test 2 + 2 returns 4.

@dkorolev

dkorolev Oct 8, 2017

Owner

Why does it make no sense? It's just to test 2 + 2 returns 4.

This comment has been minimized.

@sompylasar

sompylasar Oct 8, 2017

Collaborator

It makes no sense from the perspective of the user of this wannabe-useful npm package / cli tool.

@sompylasar

sompylasar Oct 8, 2017

Collaborator

It makes no sense from the perspective of the user of this wannabe-useful npm package / cli tool.

This comment has been minimized.

@dkorolev

dkorolev Oct 8, 2017

Owner

It makes it super-simple to test in IRL, w/ zero configuration. Why not keep it?

@dkorolev

dkorolev Oct 8, 2017

Owner

It makes it super-simple to test in IRL, w/ zero configuration. Why not keep it?

## Running the Tests
```
$ npm i

This comment has been minimized.

@sompylasar

sompylasar Oct 8, 2017

Collaborator

Better keep the long-hands in the documentation (npm install).

@sompylasar

sompylasar Oct 8, 2017

Collaborator

Better keep the long-hands in the documentation (npm install).

This comment has been minimized.

@dkorolev

dkorolev Oct 8, 2017

Owner

Why?

@dkorolev

This comment has been minimized.

@sompylasar

sompylasar Oct 8, 2017

Collaborator

Because that's what is listed in the npm documentation.

@sompylasar

sompylasar Oct 8, 2017

Collaborator

Because that's what is listed in the npm documentation.

{
"name": "curlable",
"version": "0.0.1",
"description": "A simple wrapper to turn [stateless] command-line utilities into HTTP endpoints.",

This comment has been minimized.

@sompylasar

sompylasar Oct 8, 2017

Collaborator

Square brackets look awkward here.

@sompylasar

sompylasar Oct 8, 2017

Collaborator

Square brackets look awkward here.

Show outdated Hide outdated package.json
Show outdated Hide outdated package.json
@@ -0,0 +1,42 @@
'use strict';

This comment has been minimized.

@sompylasar

sompylasar Oct 8, 2017

Collaborator

#!/usr/bin/env node and chmod +x

@sompylasar

sompylasar Oct 8, 2017

Collaborator

#!/usr/bin/env node and chmod +x

var app = express();
app.use(bodyParser.text({
type: '*/*'
}));

This comment has been minimized.

@sompylasar

sompylasar Oct 8, 2017

Collaborator

This doesn't seem to belong in here.

@sompylasar

sompylasar Oct 8, 2017

Collaborator

This doesn't seem to belong in here.

This comment has been minimized.

@dkorolev

dkorolev Oct 8, 2017

Owner

Where should it belong? I can't parse the body otherwise.

@dkorolev

dkorolev Oct 8, 2017

Owner

Where should it belong? I can't parse the body otherwise.

@dkorolev

This comment has been minimized.

Show comment
Hide comment
@dkorolev

dkorolev Oct 8, 2017

Owner

@sompylasar, thanks! PTAL @ 26a13d1.

Owner

dkorolev commented Oct 8, 2017

@sompylasar, thanks! PTAL @ 26a13d1.

@sompylasar

This comment has been minimized.

Show comment
Hide comment
@sompylasar
Collaborator

sompylasar commented on package.json in 26a13d1 Oct 8, 2017

@sompylasar

This comment has been minimized.

Show comment
Hide comment
@sompylasar

sompylasar Oct 8, 2017

Collaborator

👍

Collaborator

sompylasar commented on 26a13d1 Oct 8, 2017

👍

@dkorolev

This comment has been minimized.

Show comment
Hide comment
@dkorolev

dkorolev Oct 8, 2017

Owner

bin is an object

@sompylasar, why the fuck did npm i work then?! Ref. 580e73f

Owner

dkorolev commented Oct 8, 2017

bin is an object

@sompylasar, why the fuck did npm i work then?! Ref. 580e73f

@dkorolev

This comment has been minimized.

Show comment
Hide comment
@dkorolev

dkorolev Oct 8, 2017

Owner

@sompylasar, shall we merge this one and add one more feature today, in the next 15 minutes? :)

Owner

dkorolev commented Oct 8, 2017

@sompylasar, shall we merge this one and add one more feature today, in the next 15 minutes? :)

@sompylasar

This comment has been minimized.

Show comment
Hide comment
@sompylasar

sompylasar Oct 8, 2017

Collaborator

👍

Collaborator

sompylasar commented on 95b4c8b Oct 8, 2017

👍

@dkorolev

This comment has been minimized.

Show comment
Hide comment
@dkorolev

dkorolev Oct 8, 2017

Owner

Merging this one and creating one more, perhaps the last, PR.

Owner

dkorolev commented Oct 8, 2017

Merging this one and creating one more, perhaps the last, PR.

@dkorolev dkorolev merged commit 863e281 into master Oct 8, 2017

@sompylasar

This comment has been minimized.

Show comment
Hide comment
@sompylasar

sompylasar Oct 8, 2017

Collaborator

@dkorolev Sure, you can merge.

I'd prefer to either leave it like this, or receive more precise instructions re. what's The Node Way.

I don't think it's "the node way", it's basic OOP plus limiting the number of possible states and transitions. RAII is C++ way, btw.

From the functionality standpoint, this may have been shaped as an express middleware (createMiddleware function which returns a (req,res,next) function).

Collaborator

sompylasar commented Oct 8, 2017

@dkorolev Sure, you can merge.

I'd prefer to either leave it like this, or receive more precise instructions re. what's The Node Way.

I don't think it's "the node way", it's basic OOP plus limiting the number of possible states and transitions. RAII is C++ way, btw.

From the functionality standpoint, this may have been shaped as an express middleware (createMiddleware function which returns a (req,res,next) function).

@sompylasar

This comment has been minimized.

Show comment
Hide comment
@sompylasar

sompylasar Oct 16, 2017

Collaborator

@dkorolev npm@5.5.1:

npm notice created a lockfile as package-lock.json. You should commit this file.

https://docs.npmjs.com/files/package-lock.json

Collaborator

sompylasar commented on .gitignore in a1d1cd2 Oct 16, 2017

@dkorolev npm@5.5.1:

npm notice created a lockfile as package-lock.json. You should commit this file.

https://docs.npmjs.com/files/package-lock.json

This comment has been minimized.

Show comment
Hide comment
@sompylasar

sompylasar Oct 16, 2017

Collaborator

Which issues did you have with package-lock.json ?

Collaborator

sompylasar replied Oct 16, 2017

Which issues did you have with package-lock.json ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment