Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release JWPL 1.2.0 #158

Closed
4 tasks
reckart opened this issue May 18, 2018 · 13 comments
Closed
4 tasks

Release JWPL 1.2.0 #158

reckart opened this issue May 18, 2018 · 13 comments
Milestone

Comments

@reckart
Copy link
Member

reckart commented May 18, 2018

@reckart reckart added this to the 1.2.0 milestone May 18, 2018
@reckart
Copy link
Member Author

reckart commented May 18, 2018

@zesch @daxenberger @tgalery With #155 being merged now, it might be a good time to do a new release?

@tgalery
Copy link
Contributor

tgalery commented May 21, 2018

Might be good to go through the issues and see what should be closed as well.

@reckart
Copy link
Member Author

reckart commented May 22, 2018

Any volunteers?

@daxenberger
Copy link
Member

Any volunteers?

I can do, but not before mid June. I might also make sense to resolve #2 before a release...

@mawiesne
Copy link
Contributor

mawiesne commented Jun 27, 2018

@daxenberger We (@rzo1 and me) agree that resolving #2 is essential to move the project forward. Several issues (#160, #161) are symptoms for the lack of testability for external developers not directly working with CI servers in Darmstadt.

In an effort to keep the library alive and future-safe, we prose to conduct the following measures:

What do you think? cc: @reckart

@reckart
Copy link
Member Author

reckart commented Jun 27, 2018

@mawiesne I'm in favor of anything that is good for the project. I can help with anything that requires special permissions such as things related to the UKP CI, GitHub project configuration, etc. I can also help with handling CLAs. Unfortunately, I cannot help with implementations.

@mawiesne and @tgalery - I could whitelist you in the UKP CI such that PRs from you are automatically built and such that you could trigger builds on PRs from other people via a comment on the PR. In that way, you could run tests against the UKP database server as long as #2 has not been resolved.

@rzo1
Copy link
Contributor

rzo1 commented Jun 27, 2018

@reckart My colleague @mawiesne is preparing a PR for #2 atm, which will arrive shortly to remove the burden of MySQL driven test-cases. In the long run, we will try to add Maven profiles as well so we can build the project against MySQL databases in an integration test setup.

@mawiesne
Copy link
Contributor

@reckart Being whitelisted for UKP's CI would be n1. I'd support that. +1

@mawiesne
Copy link
Contributor

mawiesne commented Jun 27, 2018

@reckart In your first comment on this milestone you mentioned "Check dependencies". Does that include bringing frameworks such as Spring to more recent versions (i.e., 5.0+)? If so: I'd open an issue for this topic under this milestone and process it during the next 1 or 2 weeks.

@reckart
Copy link
Member Author

reckart commented Jun 27, 2018

@mawiesne that depends. E.g Spring should be updated rather conservatively, i.e. only when necessary. Same for Hibernate I guess. Upgrades to such libraries can negatively affect people that integrate JWPL into applications - but I guess you know that better :)

Other libraries (e.g. Apache Commons) should be quite safe to upgrade.

However, what I mainly meant is to ensure that:

  • there are no dependencies that are not needed
  • there are dependencies on the JARs of all classes that are directly referred (avoid relying on transitive dependencies)
  • the scope of the dependencies is correct (mainly test vs. compile)

On the projects that I maintain, I have the Maven Dependency Plugin running at least during the CI builds and in some also in all Maven builds. This checks specifically the first and the second point. The third point is not so easy to check automatically any may be better checked "by eye".

@reckart
Copy link
Member Author

reckart commented Jun 27, 2018

@mawiesne I plan to whitelist you later today when our infrastructure is back from maintenance. If for some reason, I should forget it, please prod me :)

@reckart
Copy link
Member Author

reckart commented Jun 27, 2018

@mawiesne You should be whitelisted now - meaning your PRs should be built automatically when you create one and you should also be able to say "Jenkins, can you test this please." on PRs created by others.

@daxenberger
Copy link
Member

@daxenberger We (@rzo1 and me) agree that resolving #2 is essential to move the project forward. Several issues (#160, #161) are symptoms for the lack of testability for external developers not directly working with CI servers in Darmstadt. In an effort to keep the library alive and future-safe, we prose to conduct the following measures: (...)

Sounds reasonable. No objections from my side; I'll help where necessary.
Thanks for the initiative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants