Prevent instantiation of abstract classes whose superclass isn't Object #10

Merged
merged 4 commits into from Oct 5, 2013

Projects

None yet

2 participants

@misfo
misfo commented Oct 4, 2013

Fixes #9

@dkubb
Owner
dkubb commented Oct 5, 2013

@misfo I updated the gem dependencies to use the latest devtools and brought things up to date with the standard practice in the other ROM related gems. You said you were having problems getting rake ci to even run, but it should work now and I've verified that travis passes.

Unfortunately with this upgrade I think it introduced a few merge conflicts with this PR. Would you mind fixing the conflicts and making sure the code passes with rake ci? Let me know when it's ready for review and I'll check it out.

FWIW, the general approach looks great to me. I mostly want to make sure it doesn't introduce any unkilled mutations. I also wonder if that super(*args, &block) can be changed to just super, but I suspect if it can mutant will point it out to you so I haven't tested it on my end.

@misfo
misfo commented Oct 5, 2013

Apparently implicit passing of args to super with the no-arg super syntax doesn't work within a define_method. It raises an error.

I'll try out the updated rake ci and let you know the results... Thanks for fixing that

Sent from my phone

On Oct 5, 2013, at 1:07 AM, Dan Kubb notifications@github.com wrote:

@misfo I updated the gem dependencies to use the latest devtools and brought things up to date with the standard practice in the other ROM related gems. You said you were having problems getting rake ci passing, but it should work now and I've verified that travis passes.

Unfortunately with this upgrade I think it introduced a few merge conflicts with this PR. Would you mind fixing the conflicts and making sure the code passes with rake ci? Let me know when it's ready for review and I'll check it out.

FWIW, the general approach looks great to me. I mostly want to make sure it doesn't introduce any unkilled mutations. I also wonder if that super(*args, &block) can be changed to just super, but I suspect if it can mutant will point it out to you so I haven't tested it on my end.


Reply to this email directly or view it on GitHub.

misfo added some commits Oct 5, 2013
@misfo misfo Merge branch 'master' of https://github.com/dkubb/abstract_type into …
…fix-new-method-for-classes-without-object-as-their-superclass

Conflicts:
	spec/unit/abstract_type/abstract_method_declarations/included_spec.rb
79794e5
@misfo misfo Fix some code formatting offences in the metrics 62ae009
@misfo misfo Killed the mutants 667fbda
@misfo
misfo commented Oct 5, 2013

Wow. I see why you guys use mutation testing now. Mutant pointed out exactly where the coverage had slipped up. Nice work @mbj!

rake ci is looking all good now...

@dkubb dkubb merged commit 6b1cc80 into dkubb:master Oct 5, 2013

1 check failed

Details default The Travis CI build failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment