Skip to content

Commit

Permalink
Move contribution guidelines into separate file
Browse files Browse the repository at this point in the history
  • Loading branch information
dkubb committed Oct 5, 2013
1 parent aa278ae commit 758ba48
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 9 deletions.
10 changes: 10 additions & 0 deletions CONTRIBUTING.md
@@ -0,0 +1,10 @@
# Contributing

* If you want your code merged into the mainline, please discuss the proposed changes with me before doing any work on it. This library is still in early development, and the direction it is going may not always be clear. Some features may not be appropriate yet, may need to be deferred until later when the foundation for them is laid, or may be more applicable in a plugin.
* Fork the project.
* Make your feature addition or bug fix.
* Follow this [style guide](https://github.com/dkubb/styleguide).
* Add specs for it. This is important so I don't break it in a future version unintentionally. Tests must cover all branches within the code, and code must be fully covered.
* Commit, do not mess with Rakefile, version, or history. (if you want to have your own version, that is fine but bump version in a commit by itself I can ignore when I pull)
* Run "rake ci". This must pass and not show any regressions in the metrics for the code to be merged.
* Send me a pull request. Bonus points for topic branches.
9 changes: 1 addition & 8 deletions README.md
Expand Up @@ -35,14 +35,7 @@ Foo.descendants # => [Bar]

## Contributing

* If you want your code merged into the mainline, please discuss the proposed changes with me before doing any work on it. This library is still in early development, and the direction it is going may not always be clear. Some features may not be appropriate yet, may need to be deferred until later when the foundation for them is laid, or may be more applicable in a plugin.
* Fork the project.
* Make your feature addition or bug fix.
* Follow this [style guide](https://github.com/dkubb/styleguide).
* Add specs for it. This is important so I don't break it in a future version unintentionally. Tests must cover all branches within the code, and code must be fully covered.
* Commit, do not mess with Rakefile, version, or history. (if you want to have your own version, that is fine but bump version in a commit by itself I can ignore when I pull)
* Run "rake ci". This must pass and not show any regressions in the metrics for the code to be merged.
* Send me a pull request. Bonus points for topic branches.
See [CONTRIBUTING.md](CONTRIBUTING.md) for details.

## Copyright

Expand Down
2 changes: 1 addition & 1 deletion descendants_tracker.gemspec
Expand Up @@ -15,7 +15,7 @@ Gem::Specification.new do |gem|
gem.require_paths = %w[lib]
gem.files = `git ls-files`.split($/)
gem.test_files = `git ls-files -- spec/unit`.split($/)
gem.extra_rdoc_files = %w[LICENSE README.md TODO]
gem.extra_rdoc_files = %w[LICENSE README.md CONTRIBUTING.md TODO]

gem.add_development_dependency('rake', '~> 10.1.0')
gem.add_development_dependency('rspec', '~> 2.13.0')
Expand Down

0 comments on commit 758ba48

Please sign in to comment.