Skip to content

Commit

Permalink
mime-types is a test dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
sferik committed Jun 25, 2014
1 parent 6411219 commit f49ab56
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 10 deletions.
15 changes: 6 additions & 9 deletions Gemfile
Expand Up @@ -6,16 +6,13 @@ gem 'rake'

group :test do
gem 'backports'
gem 'coveralls', :require => false
gem 'json', :platforms => [:ruby_19]
gem 'rspec', '~> 2.14'
gem 'rubocop', '>= 0.23', :platforms => [:ruby_19, :ruby_20, :ruby_21]
gem 'simplecov', :require => false
gem 'coveralls', :require => false
gem 'json', :platforms => [:ruby_19]
gem 'mime-types', '~> 1.25', :platforms => [:jruby, :ruby_18]
gem 'rspec', '~> 2.14'
gem 'rubocop', '>= 0.23', :platforms => [:ruby_19, :ruby_20, :ruby_21]
gem 'simplecov', :require => false
gem 'yardstick'
end

platforms :jruby, :ruby_18 do
gem 'mime-types', '~> 1.25'
end

gemspec
2 changes: 1 addition & 1 deletion lib/equalizer.rb
Expand Up @@ -115,7 +115,7 @@ def eql?(other)
# @api public
def ==(other)
other = coerce(other) if respond_to?(:coerce, true)
other.kind_of?(self.class) && cmp?(__method__, other)
other.is_a?(self.class) && cmp?(__method__, other)
end

end # module Methods
Expand Down

2 comments on commit f49ab56

@dkubb
Copy link
Owner

@dkubb dkubb commented on f49ab56 Jun 26, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sferik what depends on mime-types ?

@sferik
Copy link
Collaborator Author

@sferik sferik commented on f49ab56 Jun 26, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkubb coveralls depends on rest-client, which depends on mime-types. The latest versions of mime-types (2.x) are not compatible with Ruby 1.8.7, so we need to lock to specify 1.x to ensure that tests pass on Ruby 1.8.7 and REE. I made this a test dependency because Gemnasium was showing this project’s runtime dependencies as out-of-date.

Please sign in to comment.