Fix #620 #622
Fix #620 #622
Conversation
libdparse: Get support for 'throw' as a function attribute dsymbol: A bug fix that will fix issue 620 msgpack-d: Fix some deprecations and some build issues on Windows containers: Some bug fixes.
|
Looks like I have to revert the msgpack upgrade because the ldc Windows cross-compile doesn't work. |
common/dub.sdl
Outdated
| @@ -4,5 +4,5 @@ preGenerateCommands "rdmd \"$PACKAGE_DIR/dubhash.d\"" | |||
| sourcePaths "src" | |||
| importPaths "src" | |||
|
|
|||
| dependency "msgpack-d" version="~>1.0.0-beta.7" | |||
| dependency "msgpack-d" version="~>1.0.1" | |||
There was a problem hiding this comment.
as this is stable now (according to SemVer) we could use ~>1.0 which will be any version >=1.0.0 <2.0.0 which should not get any backwards incompatible changes
There was a problem hiding this comment.
"Should" is the correct word here. This actually needs to point at 1.0.1 only. The CI fails for any version of msgpack-d that includes this commit: msgpack/msgpack-d@a23181e
There was a problem hiding this comment.
I'm not sure if this is a problem with msgpack-d, or a problem with the release build script. I'm not very familiar with cross-compiling Windows binaries with LDC.
|
about 08e0b62: you only changed the minimum version, dub will still resolve to always the highest version (so both resolve to 1.0.3) - are you sure that was the issue and it wasn't just a random one? |
|
@WebFreak001 Are you able to take another look at this? |
|
testing it continuously over the course of the day now |
|
oh yeah it was good |
No description provided.