Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement bitfield parsing #476

Merged
merged 3 commits into from
Nov 9, 2022

Conversation

WebFreak001
Copy link
Member

@WebFreak001 WebFreak001 commented Nov 8, 2022

fixes #464

should get merged soon, because of new DMD release around the corner, so would like a quick review ^^

upstream DMD implementation: https://github.com/dlang/dmd/blob/a7f8c84d405df2c0dd8929d2479c1760f61762e0/compiler/src/dmd/parse.d#L4621

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #476 (4be179e) into master (7348c5f) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
+ Coverage   83.27%   83.33%   +0.05%     
==========================================
  Files          11       11              
  Lines        8378     8402      +24     
==========================================
+ Hits         6977     7002      +25     
+ Misses       1401     1400       -1     
Impacted Files Coverage Δ
src/dparse/ast.d 70.83% <100.00%> (+0.23%) ⬆️
src/dparse/astprinter.d 94.95% <100.00%> (+0.02%) ⬆️
src/dparse/formatter.d 46.46% <100.00%> (+0.47%) ⬆️
src/dparse/parser.d 91.42% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7348c5f...4be179e. Read the comment docs.

@WebFreak001 WebFreak001 marked this pull request as draft November 8, 2022 01:44
@WebFreak001 WebFreak001 marked this pull request as ready for review November 8, 2022 01:55
@WebFreak001
Copy link
Member Author

gonna merge this because release is nearing (in 5 days)

@WebFreak001 WebFreak001 merged commit 94cc2ef into dlang-community:master Nov 9, 2022
@WebFreak001 WebFreak001 deleted the add-bitfields branch November 9, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for bitfields
1 participant