Use OR for twitter widget and disable retweets #115
Conversation
| @@ -2,6 +2,10 @@ ifeq (,$(OUT)) | |||
| $(error you must define OUT) | |||
| endif | |||
|
|
|||
| ifeq (,$(DMD)) | |||
| DMD = ../../dmd/src/dmd | |||
There was a problem hiding this comment.
or is just DMD = dmd better?
|
changed dmd to |
| @@ -79,7 +79,7 @@ $(DIV class="page_right equal", | |||
| ) | |||
| $(DIV class="twitter", | |||
| $(DIV class="hash", ) | |||
| <a class="twitter-timeline" href="https://twitter.com/search?q=%23dconf+%23dlang" data-widget-id="405059685734023169">Tweets about "#dconf #dlang"</a> | |||
| <a class="twitter-timeline" href="https://twitter.com/search?q=%23dconf+%23dlang-RT" data-widget-id="726813389926883328">Tweets about "#dconf #dlang"</a> | |||
There was a problem hiding this comment.
I think this misses a plus sign in the href value, before -RT. Maybe just copy the code that Twitter gives you.
I don't want to control them either. I don't even use Twitter. |
done ;-) |
| @@ -79,7 +79,7 @@ $(DIV class="page_right equal", | |||
| ) | |||
| $(DIV class="twitter", | |||
| $(DIV class="hash", ) | |||
| <a class="twitter-timeline" href="https://twitter.com/search?q=%23dconf+%23dlang" data-widget-id="405059685734023169">Tweets about "#dconf #dlang"</a> | |||
| <a class="twitter-timeline" href="https://twitter.com/search?q=%23dconf%20%23dlang%20-RT" data-widget-id="726813389926883328">Tweets about "#dconf #dlang"</a> | |||
There was a problem hiding this comment.
You added an extra space now, before href. Or does Twitter give it out like that?
There was a problem hiding this comment.
yes, but i can also remove it ;-)
There was a problem hiding this comment.
btw I realized that according to the twitter search we should better use an "OR", otherwise the operators will be joined...
|
update: it turns out that we have a real bug here - we join the twitter hashtags. According to the twitter search API we should use an "OR". |
wilzbach
changed the title
I'm not so sure about that. There's a config tool called dconf, and apparently another conference going by the same name. It may have been the plan to always use both #dlang and #dconf to avoid confusion. Also, posts with just #dlang aren't so interesting on the dconf site. |
I think everyone is just using "#dconf", see: |
Maybe go with just #dconf then. False positives may be the lesser evil. I don't think we need tweets with just #dlang on dconf.org, so I'm not for |
It's just that over the entire year "#dconf" is not used a lot, so the widget will look "old". I think that the author of this wanted to have both tags with "or", but didn't know that they are "and" joined. ping @CyberShadow - can we get this in while #dconf is still running? ;-) |
|
Sorry this didn't get sorted out - will close for now. Thx! |
See: http://forum.dlang.org/thread/uakjmhiwkvvveeekzkgw@forum.dlang.org
Ignores retweets on the Twitter widget.
Moreover I added the DMD compiler env constant to the makefile if it isn't defined.