Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention all approving reviewers in the commit message #275

Merged
merged 2 commits into from May 28, 2021
Merged

Mention all approving reviewers in the commit message #275

merged 2 commits into from May 28, 2021

Conversation

CyberShadow
Copy link
Member

Fixes #181.

@dlang-bot
Copy link
Collaborator

Thanks for your pull request, @CyberShadow!

@Geod24 Geod24 merged commit 66b417a into dlang:master May 28, 2021
@kinke
Copy link

kinke commented May 28, 2021 •
edited

Note that the bot seems to close DMD bugzilla issues matching the number of the actually fixed GitHub dlang-bot issue here - e.g., this has closed a 15-year old DMD bug: https://issues.dlang.org/show_bug.cgi?id=181

@CyberShadow
Copy link
Member Author

Yes, that's #259. Fixed and I just switched webhooks to the new instance which has the bugfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geod24 Geod24 Geod24 approved these changes

Assignees
No one assigned
Labels
Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mention all approving reviewers in the commit message
4 participants
@CyberShadow @dlang-bot @kinke @Geod24