add trello tests #36
Merged
add trello tests #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MartinNowak
commented
Dec 24, 2016
MartinNowak
commented
- bugzilla, and gh links
- moving cards
- bugzilla, and gh links - moving cards
MartinNowak
force-pushed
the
trelloTests
branch
from
53e1d18 to
5eb98cd
Compare
wilzbach
approved these changes
Dec 24, 2016
Contributor
wilzbach
left a comment
wilzbach
left a comment
There was a problem hiding this comment.
Looks very good to me - more testing :)
The list of called URLs gets longer and longer, so it might be a bit annoying if we add more features, but OTOH I prefer explicitness.
Contributor
|
Neat!
|
Member
Author
|
Was thinking about some wildcard in the expectations, but it's fine for now, will be a pain to modify and maintain though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.