Skip to content

Conversation

@MartinNowak
Copy link
Member

No description provided.

@MartinNowak
Copy link
Member Author

Weirdly enough breaks unrelated trello tests, apparently because of some parse failure of the bug refs in comments (detecting fixed as false).
Almost looks like a memory corruption or so.
Maybe we should use a little less range chaining there?

@wilzbach
Copy link
Contributor

wilzbach commented Jun 15, 2017

Almost looks like a memory corruption or so.

Hmm, if I set the log-level to debug, the errors goes away:

setLogLevel(LogLevel.debug_);

Also this patch moves the error to the next test:

diff --git a/test/utils.d b/test/utils.d
index 6740430..d5e2091 100644
--- a/test/utils.d
+++ b/test/utils.d
@@ -123,9 +127,12 @@ auto payloadServer(scope HTTPServerRequest req, scope HTTPServerResponse res)
             if (expectation.jsonHandler !is null)
                 expectation.jsonHandler(payloadJson);
 
-            payload = payloadJson.toString;
+            return res.writeJsonBody(payloadJson);
+        }
+        else
+        {
+            return res.writeBody(payload);
         }
-        return res.writeBody(payload);
     }
 }

@wilzbach
Copy link
Contributor

Almost looks like a memory corruption or so.

It seems it's more a multi-threading issue in our test script ...

-> the cruel __gshared and synchronized seem to work fine :)

@wilzbach
Copy link
Contributor

Hmm LDC doesn't seem to like it:

image

@wilzbach
Copy link
Contributor

But ldc-beta does work:

image

@wilzbach
Copy link
Contributor

LDC is broken in #78 as well:

image

So I am giving this a go & deploying it.

@dlang-bot dlang-bot merged commit 8153e4d into dlang:master Jun 22, 2017
@wilzbach
Copy link
Contributor

Activated the scheduler: https://scheduler.heroku.com/dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants