Replace "Page wiki" button with new "Report a bug" button #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -211,6 +211,12 @@ _= | |||
| PAGE_TOOLS= | |||
| $(DIVID tools, | |||
| $(SPANC tip, | |||
| <a href="https://issues.dlang.org/enter_bug.cgi?bug_file_loc=http%3A%2F%2Fdlang.org/$(SELF_PATH)&bug_severity=enhancement&component=$(BUGZILLA_COMPONENT)&op_sys=All&priority=P3&product=D&rep_platform=All&short_desc=%5B$(TITLE)%5D&version=D2" class="button">Report a bug</a> | |||
There was a problem hiding this comment.
$(HTMLTAG3 a, href="..." class="button", Report a bug)
There was a problem hiding this comment.
Eh, done, but I don't see the point frankly. It's longer and carries no semantic meaning (there is no meaningful alternative value for HTMLTAG3 one may want to use)..
There was a problem hiding this comment.
Plus it's now inconsistent with the other button's HTML code. Such changes are probably better done separately.
CyberShadow
force-pushed
the
pull-20150609-004423-reportbugbtn
branch
from
6506ce4 to
6521402
Compare
| @@ -1,5 +1,7 @@ | |||
| ROOT_DIR = | |||
| ROOT = . | |||
| SELF_PATH = | |||
| BUGZILLA_COMPONENT = websites | |||
There was a problem hiding this comment.
Oops, these just changed, please replace: http://beta.forum.dlang.org/post/ml5tr4$1na4$1@digitalmars.com
There was a problem hiding this comment.
Done - turns out we don't need BUGZILLA_COMPONENT now, because we already have PROJECT :)
CyberShadow
force-pushed
the
pull-20150609-004423-reportbugbtn
branch
from
6521402 to
138b471
Compare
andralex
added a commit
that referenced
this pull request
Jun 9, 2015
…bugbtn Replace "Page wiki" button with new "Report a bug" button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: https://issues.dlang.org/show_bug.cgi?id=14668