Introduce SystemZ version identifier and deprecate S390X. #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new 64-bit architecture is called System z. IMHO we should use this name instead the cryptic S390X.
redstar
added a commit
to redstar/dmd
that referenced
this pull request
Sep 19, 2015
This is a better name than S390X. The doc update is here: dlang/dlang.org#1100 If this gets pulled then I also update druntime to use SystemZ.
|
See dlang/dmd#5101 and ldc-developers/ldc#1091. |
|
Whoops I forgot I don't have merge rights. Anyway LGTM. |
|
@WalterBright @andralex: Could you sort out Daniel's commit permissions please? |
dnadlinger
added a commit
that referenced
this pull request
Sep 19, 2015
Introduce SystemZ version identifier and deprecate S390X.
|
If you are going to do any work on actually making D work on that target, now is definitely the time to make the change. I didn't worry too much about backwards-compatibility implications when pressing the merge button because the chance that significant amounts of code for this target exist in the wild (outside of Kai's work) is pretty small. |
|
I already changed the druntime source: dlang/druntime#1392 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new 64-bit architecture is called System z. IMHO we should
use this name instead the cryptic S390X.