-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix example on the front page #1205
Conversation
|
I wish the LGTM |
IMHO it's less weird than scaring people into thinking that they must always specify a sort predicate. |
Reverse order? |
|
Could you add "in reverse order" to the top comment then? Might be a bit non-obvious to new visitors otherwise. That being said, I guess this case would also be a good example for showing off |
|
LGTM. |
|
@9il Add the comment about reverse order and I'll merge this too. |
done |
|
I think you need to also update the example hash in |
done |
|
Thanks |
.sortis deprecated property. In the same time.sort()looks weird.