Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example on the front page #1205

Merged
merged 1 commit into from
Apr 17, 2016
Merged

Fix example on the front page #1205

merged 1 commit into from
Apr 17, 2016

Conversation

9il
Copy link
Member

@9il 9il commented Jan 18, 2016

.sort is deprecated property. In the same time .sort() looks weird.

@9il 9il changed the title Fix index example Fix example on the from page Jan 18, 2016
@JackStouffer
Copy link
Member

I wish the sort property would get removed some day soon.

LGTM

@CyberShadow
Copy link
Member

In the same time .sort() looks weird.

IMHO it's less weird than scaring people into thinking that they must always specify a sort predicate.

@9il
Copy link
Member Author

9il commented Jan 19, 2016

IMHO it's less weird than scaring people into thinking that they must always specify a sort predicate.

Reverse order? .sort!((a, b) => a > b)

@dnadlinger
Copy link
Member

Could you add "in reverse order" to the top comment then? Might be a bit non-obvious to new visitors otherwise. That being said, I guess this case would also be a good example for showing off .retro. ;)

@quickfur
Copy link
Member

LGTM.

@adamdruppe
Copy link
Contributor

@9il Add the comment about reverse order and I'll merge this too.

@schuetzm schuetzm changed the title Fix example on the from page Fix example on the front page Apr 13, 2016
@9il
Copy link
Member Author

9il commented Apr 17, 2016

@9il Add the comment about reverse order and I'll merge this too.

done

@CyberShadow
Copy link
Member

I think you need to also update the example hash in js/run-main-website.js so that the input is carried along. (See the commentary at the top of js/run.js for instructions.)

@9il
Copy link
Member Author

9il commented Apr 17, 2016

I think you need to also update the example hash in js/run-main-website.js so that the input is carried along. (See the commentary at the top of js/run.js for instructions.)

done

@CyberShadow
Copy link
Member

Thanks

@CyberShadow CyberShadow merged commit f8ef348 into dlang:master Apr 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants