Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CodeMirror #1206

Merged
merged 1 commit into from
Jan 19, 2016
Merged

Update CodeMirror #1206

merged 1 commit into from
Jan 19, 2016

Conversation

CyberShadow
Copy link
Member

@aG0aep6G
Copy link
Contributor

Bastiaan Veelo, who reported the issue to bugzilla, has confirmed the fix, and the files are just those from CodeMirror. So, LGTM.

@CyberShadow
Copy link
Member Author

Of note is that to get codemirror-compressed.js, you have to follow a wizard, where you select which syntax, themes etc. you want to support. I don't know what settings were used originally, but the ones I used (D syntax and nothing else) seem to work fine in practice.

@dnadlinger
Copy link
Member

Yep, seems to work fine on Safari 9.0.2 now.

dnadlinger added a commit that referenced this pull request Jan 19, 2016
@dnadlinger
Merge pull request #1206 from CyberShadow/pull-20160119-080751
c70b5f7 
Update CodeMirror
@dnadlinger dnadlinger merged commit c70b5f7 into dlang:master Jan 19, 2016
@aG0aep6G
Copy link
Contributor

Has this been pushed online? Can the issue be marked fixed?

@CyberShadow
Copy link
Member Author

It is now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CyberShadow @aG0aep6G @dnadlinger