Add caveat for opApply and exceptions. #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Link to discussion: https://forum.dlang.org/post/n8ptpu$1ncu$1@digitalmars.com |
| $(P It is important to make sure that, if $(D opApply) catches any exceptions, that those | ||
| exceptions did not origin at the delegate passed to $(I opApply). Catching an exception | ||
| that escaped from the delegate would cause a condition that the user expected would terminate | ||
| the loop to not do so. |
There was a problem hiding this comment.
- "origin at" -> originate from
- The last sentence is cryptic. Possibly better: "The user would expect exceptions thrown from a
foreachbody to both terminate the loop, and propagate outside theforeachbody."
There was a problem hiding this comment.
Also, that appears twice: "make sure that, ..., that those"
|
@Shachar if you update the wording a bit from the comments, i'll pull this. |
|
Hi @Shachar, could you amend the suggested fixes? If you do not have the time we can take over. Thanks! |
|
I'll pull now and make the changes as a fixup. |
andralex
approved these changes
Dec 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on the forum, add explanation about exception handling inside opApply, and their interaction with exceptions thrown from within the opApply delelgate.