Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve runnable: disable assert to writeln transformation + make output a pre element #1575

Merged
merged 2 commits into from Feb 20, 2017

Conversation

wilzbach
Copy link
Member

As of http://forum.dlang.org/post/enjjesmilghothyjlfid@forum.dlang.org

  1. the Regex doesn't seem to handle all cases of assert -> removed
  2. textarea shouldn't be used for a readonly output -> pre
  3. For consistency I also moved the separated CSS up into its group

@JackStouffer
Copy link
Member

I'm getting "temporarily unavailable" errors when I try to test this.

@wilzbach
Copy link
Member Author

I'm getting "temporarily unavailable" errors when I try to test this.

Yeah @nazriel doesn't allow CORS requests from the DAutoTest domain (dtest.dlang.io). I have written to him about this for a couple of times already since the last six months. Unfortunately as you have realized with no effect.

@wilzbach
Copy link
Member Author

For reference:
@JackStouffer If you open your console you should see something like:

XMLHttpRequest cannot load https://dpaste.dzfl.pl/request/. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://dtest.dlang.io' is therefore not allowed access.

@wilzbach
Copy link
Member Author

Ping @CyberShadow or @andralex for merging this fix, s.t. we can post an announcement to reddit ;-)

@andralex
Copy link
Member

Cool. Not a fan of the rewrite assert->writeln in the first place...

@andralex andralex merged commit af1b24d into dlang:master Feb 20, 2017
@CyberShadow
Copy link
Member

Thx. If possible, it would be nice to put all information describing a change in the commit message itself, e.g. what the assert rewrite was (I had no idea) and the justification for the HTML change.

@wilzbach wilzbach deleted the improve-runnable branch February 20, 2017 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants