Skip to content

Conversation

@alouanchi
Copy link
Contributor

@alouanchi alouanchi commented Apr 8, 2017

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Apr 8, 2017

Fix Bugzilla Description
17303 type error in the href url under the link Systems Programming

@alouanchi alouanchi changed the title Issue 17303 - areas-of-d-usage.dd Fix Issue 17303 - areas-of-d-usage.dd Apr 8, 2017
@alouanchi alouanchi changed the title Fix Issue 17303 - areas-of-d-usage.dd Fix Issue 17303 - type error in the href url under the link Systems Programming Apr 8, 2017
@aG0aep6G
Copy link
Contributor

aG0aep6G commented Apr 8, 2017

This fixes the same issue as my #1621. I should probably have expressed more explicitly in Bugzilla that I'm submitting a fix.

Ideally, you'd change the commit message to include the word "fix". The bot picks it up then, which automates a couple of things. I don't know if you can do that with GitHub's web interface. You may have to make a local clone for this. If you have experience with git, it should be relatively straight-forward (pull, amend, force push). If you don't know git, you'd probably have to learn some basics first. If this is too much hassle, I can proceed with #1621 instead. But if you want you're very welcome to go through with this.

On the actual changes: Changing the target ID is a minor breaking change. If anyone has a link/bookmark to #system-programming, you're breaking that link. I don't know how important it is to keep this particular URL alive, but generally we try not to break them.

@alouanchi
Copy link
Contributor Author

alouanchi commented Apr 8, 2017

Thanks for your comments,
I will give it a try.

@alouanchi
Copy link
Contributor Author

I have updated my commit to follow @aG0aep6G advice.

@aG0aep6G I agree changing the target ID may break saved links and as our fix is the same is up to you to merge the one you want.

@aG0aep6G thanks a lot for you help.

@aG0aep6G
Copy link
Contributor

aG0aep6G commented Apr 8, 2017

@aG0aep6G I agree changing the target ID may break saved links and as our fix is the same is up to you to merge the one you want.

I don't have merge rights. We'll have to wait for a team member to take a look. I've closed my PR, so it's all yours now.

@aG0aep6G thanks a lot for you help.

You're welcome.

@CyberShadow
Copy link
Member

I'm fine with the ID breakage in this case, as this is a relatively new page and is not part of the language spec.

@dlang-bot dlang-bot merged commit 048ba72 into dlang:master Apr 8, 2017
@aG0aep6G
Copy link
Contributor

aG0aep6G commented Apr 8, 2017

I'm fine with the ID breakage in this case, as this is a relatively new page and is not part of the language spec.

Note that @alouanchi has removed the ID change. No breakage here.

@CyberShadow
Copy link
Member

Thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants