Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add link to the wiki in arrays.dd #1634

Merged
merged 1 commit into from
Mar 3, 2022
Merged

add link to the wiki in arrays.dd #1634

merged 1 commit into from
Mar 3, 2022

Conversation

9il
Copy link
Member

@9il 9il commented Apr 13, 2017

arrays.dd contains rectangular-arrays section.
Motivation: http://forum.dlang.org/post/fsaohvwffyxgtlbholhv@forum.dlang.org

@JackStouffer
Copy link
Member

I don't know about this. Should we really be promoting a third party library in the spec itself?

@CyberShadow
Copy link
Member

I don't know about this. Should we really be promoting a third party library in the spec itself?

No, we shouldn't.

@9il
Copy link
Member Author

9il commented Apr 14, 2017

The paragraph should cover somehow that dynamics tensors are exists. Can this be replaced with: See also https://wiki.dlang.org/Dense_multidimensional_arrays ? Please reopen at least for others to see and discuss it.

@CyberShadow
Copy link
Member

Please reopen at least for others to see and discuss it.

OK. But I still don't think the spec is a place to list third-party libraries and such.

The spec is supposed to be, well, the specification: It's meant as a technical reference for implementers and speaks about the language itself. It makes very few references even to the standard library, much less third-party libraries.

We used to have articles hosted on dlang.org. I think the best place to improve ndslice visibility is an article on wiki.dlang.org, which can be linked from the site navigation (Documentation -> Articles).

@CyberShadow CyberShadow reopened this Apr 14, 2017
@wilzbach
Copy link
Member

wilzbach commented May 6, 2017

Hmm ndslice has been a part of Phobos and as such isn't a usual third-party library as people might still be using ndslice from std.experimental, also there are precedents of linking to other projects from the spec. Just by quickly browsing I found this:

So imho we should at least link to the wiki and even linking to Mir would be helpful as it's the de-facto library for multi-dimensional data in which most readers might be interesting. However, as the later is controversial, I am just voting for the wiki link ;-)

@9il
Copy link
Member Author

9il commented May 6, 2017

Updated with the wiki link

Copy link
Member

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilzbach
Copy link
Member

wilzbach commented Jun 7, 2017

@CyberShadow @JackStouffer are you okay with linking to the Wiki? (this happens fairly often in the specs).

@CyberShadow
Copy link
Member

Link to Deimos: https://dlang.org/spec/interfaceToC.html

Deimos is not third-party, it is managed by the same people managing github.com/dlang.

std.experimental.allocator: https://dlang.org/spec/cpp_interface.html

That's in the standard library.

and even linking to Mir would be helpful

Here is why I am concerned:

  1. Once we have one link to a third-party library in the spec, this sets a precedent and everyone with their own pet library will have a justification of adding a link to it in the spec.

  2. Because the two are different projects managed by different people, there is no guarantee that Mir will be around as long as the D programming language is. I am reminded of http://www.digitalmars.com/d/dlinks.html, which may have made sense 10-15 years ago when the community was small, but has been a link graveyard for a very long time now.

  3. As I said before, the spec is a technical document describing the language itself. Recommendations for third-party libraries are out of place there.

Therefore I'm still uneasy about this change as it is. Please move the link to http://dlang.org/articles.html and leave http://dlang.org/spec/arrays.html unchanged.

@CyberShadow
Copy link
Member

Actually it looks mostly fine now. Only nit is that the wiki article should be presenting built-in solutions first and third-party libraries afterwards. Link text could be a bit better. Could use a second opinion, @JackStouffer ?

@9il
Copy link
Member Author

9il commented Jun 8, 2017

Native D has not built-in multidimensional arrays. Only arrays of arrays.

@wilzbach
Copy link
Member

Actually it looks mostly fine now. Only nit is that the wiki article should be presenting built-in solutions first and third-party libraries afterwards. Link text could be a bit better. Could use a second opinion, @JackStouffer ?

Ping @JackStouffer or maybe @jmdavis ?

@9il 9il changed the title add link to ndslice in arrays.dd add link to the wiki in arrays.dd Jun 15, 2017
@dlang-bot dlang-bot removed the stalled label Mar 3, 2022
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @9il!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@dkorpel
Copy link
Contributor

dkorpel commented Mar 3, 2022

Only nit is that the wiki article should be presenting built-in solutions first and third-party libraries afterwards.

Looks like that's the case now

@dlang-bot dlang-bot merged commit 6254a91 into dlang:master Mar 3, 2022
@9il 9il deleted the patch-3 branch March 4, 2022 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants