-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add link to the wiki in arrays.dd #1634
Conversation
|
I don't know about this. Should we really be promoting a third party library in the spec itself? |
No, we shouldn't. |
|
The paragraph should cover somehow that dynamics tensors are exists. Can this be replaced with: See also https://wiki.dlang.org/Dense_multidimensional_arrays ? Please reopen at least for others to see and discuss it. |
OK. But I still don't think the spec is a place to list third-party libraries and such. The spec is supposed to be, well, the specification: It's meant as a technical reference for implementers and speaks about the language itself. It makes very few references even to the standard library, much less third-party libraries. We used to have articles hosted on dlang.org. I think the best place to improve ndslice visibility is an article on wiki.dlang.org, which can be linked from the site navigation (Documentation -> Articles). |
|
Hmm ndslice has been a part of Phobos and as such isn't a usual third-party library as people might still be using ndslice from
So imho we should at least link to the wiki and even linking to Mir would be helpful as it's the de-facto library for multi-dimensional data in which most readers might be interesting. However, as the later is controversial, I am just voting for the wiki link ;-) |
|
Updated with the wiki link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@CyberShadow @JackStouffer are you okay with linking to the Wiki? (this happens fairly often in the specs). |
Deimos is not third-party, it is managed by the same people managing github.com/dlang.
That's in the standard library.
Here is why I am concerned:
Therefore I'm still uneasy about this change as it is. Please move the link to http://dlang.org/articles.html and leave http://dlang.org/spec/arrays.html unchanged. |
|
Actually it looks mostly fine now. Only nit is that the wiki article should be presenting built-in solutions first and third-party libraries afterwards. Link text could be a bit better. Could use a second opinion, @JackStouffer ? |
|
Native D has not built-in multidimensional arrays. Only arrays of arrays. |
Ping @JackStouffer or maybe @jmdavis ? |
|
Thanks for your pull request, @9il! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
Looks like that's the case now |
arrays.dd contains rectangular-arrays section.
Motivation: http://forum.dlang.org/post/fsaohvwffyxgtlbholhv@forum.dlang.org