Issue 17419 - add __traits(getLinkage, s) to the the linkage of symbol s #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| alias aliasc = fooc; | ||
|
|
||
| static assert(__traits(getLinkage, fooc) == "C"); | ||
| static assert(__traits(getLinkage, aliasc) == "C"); |
There was a problem hiding this comment.
I'd add tests for a few of the other linkages too (so we are sure it doesnt always return "C" ;). And also for implicit extern(D), for a pointer to function, and perhaps for a lambda and class method.
There was a problem hiding this comment.
That's already in dmd's testsuite, btw: https://github.com/dlang/dmd/pull/6823/files#diff-4fa5742db248994843ba04a77a6d70f1L17
There was a problem hiding this comment.
Ah, sorry, I didn't see that this is in a spec file. Disregard!
wilzbach
approved these changes
Jun 7, 2017
There was a problem hiding this comment.
LGTM - @WalterBright you had merge conflicts due to the other traits PRs. I rebased yours ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.