Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to release description on downloads.dd #1697

Merged
merged 2 commits into from
Dec 12, 2017

Conversation

wilzbach
Copy link
Member

Cherry-picked from #1694 as this was controversial:

Not sure about making the platform name a link to the documentation. I'd think that being on the
download page, clicking it would take me to all Windows downloads.

We could also add a link "Docs", but I though that this is the leaner way to do it.

@CyberShadow
Copy link
Member

Hmm, how about something like show an 🛈 on hover next to the platform name that links to the help page or something like that?

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach
Copy link
Member Author

wilzbach commented Dec 7, 2017

Hmm, how about something like show an 🛈 on hover next to the platform name that links to the help page or something like that?

Before:

image

After:

image

@CyberShadow
Copy link
Member

.download_paragraph > span {
    visibility: hidden;
    font-size: 125%;
}
.download_paragraph:hover > span {
    visibility: visible;
}

?

@wilzbach
Copy link
Member Author

Well I like the increased font-size, but I personally don't like user interfaces on which I don't immediately see all buttons, but I don't feel strongly about this & would like to move forward here
-> I added your CSS definitions -> should be good to go?

@CyberShadow
Copy link
Member

Not everything on the page is equally important, so bombarding visitors with visual clutter won't result in the best experience. CSS hover tricks are probably not the best way to avoid that, but I think it's still better than nothing.

Copy link
Member

@CyberShadow CyberShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not waiting for the autotester (going to bed) but if it looks good, feel free to merge it.

@wilzbach wilzbach merged commit 163e5fd into dlang:master Dec 12, 2017
@wilzbach wilzbach deleted the link-to-docs-on-download branch December 12, 2017 10:58
@MartinNowak
Copy link
Member

I've first taken this for a security warning or sth. Looks definitely more like an alert than an info. Let's better change the font color to blue or black.


$(DOWNLOAD $(FEDORA)   $(CENTOS), Fedora/CentOS, $(SBTN $(RPM32), i386) $(SBTN $(RPM64), x86_64) $(SBTN $(ARCH linux, tar.xz), tar.xz))
$(DOWNLOAD Fedore/CentOS, $(FEDORA)   $(CENTOS), linux,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's "Fedora", not "Fedore".

@CyberShadow
Copy link
Member

-> #2059

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants