New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 17644 - [Downloads] Bad link to changelog for DMD beta version #1820
Conversation
Link for Beta is okay now, but for Nightly there is a link to changelog/<!--UNDEFINED MACRO:. Maybe $(NIGHTLIES_DMDV2) ? |
@@ -104,7 +104,8 @@ $(DIVC download_channels, | |||
) | |||
|
|||
$(DIVC download_channel, | |||
$(H2 $(LNAME2 dmd-nightly,DMD Nightly)) | |||
$(H2 $(LNAME2 dmd-nightly,DMD Nightly ($(NIGHTLIES_DMDV2)))) | |||
$(LINK2 changelog/$(NIGHTLIES_DMDV2)_pre.html, Changelog) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be _pending here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, so why isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cause there are days where I am traveling and can only do stuff on my phone ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want me to fix that for you then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you think it's critical, feel free to go ahead. Otherwise I can get to it tomorrow.
Thanks, but I can't see this on DAutoTest (click on details at the CI). If you tried this locally, you need to nuke |
"nuke generated"? Hmm, CONTRIBUTING.md seems inadequate. See also https://issues.dlang.org/show_bug.cgi?id=17649. Anyway the download page generated by DAutoTest looks good, so original bug can be closed. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn't look like the right solution for the beta changelog, adding a link to the pending nightly changelog seems fine, but they also shouldn't be under _pre.html maybe.
@@ -83,7 +83,7 @@ $(DIVC download_channels, | |||
$(BETA | |||
$(DIVC download_channel, | |||
$(H2 $(LNAME2 dmd_beta,DMD Beta $(B_DMDV2)-$(B_SUFFIX))) | |||
$(LINK2 changelog/$(B_DMDV2).html, Changelog) | |||
$(LINK2 changelog/$(B_DMDV2)_pre.html, Changelog) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far we made the beta changelog from 2.075.0_pre.dd to 2.075.0.html, something went wrong to make a _pre.html from a (generated?) _pre.dd changelog instead.
Ah apparently this was changed/broken with #1817. What's the point of the |
This is superfluous with the new changes to the changelog, e.g. |
No description provided.