Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grammar.dd to support Elvis operator #1917

Closed
wants to merge 1 commit into from

Conversation

RazvanN7
Copy link
Contributor

After (and if) [1] is merged.

[1] dlang/dmd#7242

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@jacob-carlborg
Copy link
Contributor

I think this [1] should be updated as well.

[1] https://dlang.org/spec/expression.html#conditional_expressions

@RazvanN7 RazvanN7 mentioned this pull request Oct 25, 2017
@RazvanN7
Copy link
Contributor Author

@jacob-carlborg There it is. I made a separate PR since it was easier to just select "Improve this page", then manually make a PR.

@andralex
Copy link
Member

Closing pending DIP if anyone takes it.

@andralex andralex closed this Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants