-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update expression.dd #1918
Update expression.dd #1918
Conversation
|
Thanks for your pull request, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some tips to help speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
spec/expression.dd
Outdated
| ) | ||
|
|
||
| $(P The first expression is converted to $(D bool), and is evaluated. | ||
| ) | ||
|
|
||
| $(P If it is $(D true), then the second expression is evaluated, and | ||
| its result is the result of the conditional expression. | ||
| $(P If it is $(D true) and the second expression is provided, then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two spaces between and and the.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jacob-carlborg don't forget you can edit PRs directly for such things (I'll do it just now)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested this but the documentation says:
"You can only make commits on pull request branches that: are opened in a repository that you have push access to and that were created from a fork of that repository" [1]
[1] https://help.github.com/articles/committing-changes-to-a-pull-request-branch-created-from-a-fork/
|
Closing pending DIP if anyone takes it. |
Part 2 of #1917