Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End the deprecation period of using the result of a comma expression #2151

Merged
merged 1 commit into from
Feb 6, 2018
Merged

End the deprecation period of using the result of a comma expression #2151

merged 1 commit into from
Feb 6, 2018

Conversation

wilzbach
Copy link
Member

See also: dlang/dmd#7813

@wilzbach wilzbach mentioned this pull request Jan 31, 2018
Merged
@quickfur
Copy link
Member

Finally! About time the comma operator died a long-overdue death!

@MetaLang
Copy link
Member

Hasn't this only been deprecated since mid-late 2016?

@wilzbach
Copy link
Member Author

Hasn't this only been deprecated since mid-late 2016?

I thought that deprecations are for one generous year, but Martin recently reclarified this dlang/dmd#6676 (comment):

We have a general schedule for deprecations (6 months), but deviate from that when it seems too disturbing.

@JackStouffer
Copy link
Member

JackStouffer commented Jan 31, 2018 •
edited
Loading

We really need to make an official document standardizing the deprecation process. Everytime we do this we can't agree on the flow or the time between steps.

I think I'll write a short DIP; thoughts?

@wilzbach
Copy link
Member Author

I think I'll write a short DIP; thoughts?

Yes, please ❤️

I assume you are aware of the recent discussion here: dlang/phobos#6086 (comment)?

(As always: feel free to ping us on Slack if we can help.)

@dlang-bot dlang-bot merged commit 88cda4f into dlang:master Feb 6, 2018
@quickfur
Copy link
Member

quickfur commented Feb 6, 2018

The DMD pull has merged. This goes in now.

Yes!!!! Finally, the bad old comma operator is DEAD!

@wilzbach wilzbach deleted the comma-exp branch February 6, 2018 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andralex andralex andralex approved these changes

@WalterBright WalterBright Awaiting requested review from WalterBright WalterBright is a code owner

Assignees
No one assigned
Labels
auto-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wilzbach @quickfur @MetaLang @JackStouffer @andralex @dlang-bot