Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always display the download icon #2154

Merged
merged 1 commit into from
Feb 15, 2018

Conversation

wilzbach
Copy link
Member

Based on feedback from the NG:

https://dlang.org/install.html
I've never seen that page. Would've helped me to see it earlier. The D download page should include a blurb with a link to that install page.
https://forum.dlang.org/post/zwizsobrbboibzqrussm@forum.dlang.org

From @quickfur:

Wow. I set out deliberately looking for that link, and couldn't find it until I looked at your screenshot. I definitely wouldn't have found it if I didn't even know it was there.
https://forum.dlang.org/post/mailman.2877.1517420581.9493.digitalmars-d@puremagic.com

The info buttons have been added in: #1697

And the install.sh page was added in: #1936

@wilzbach
Copy link
Member Author

Before:

image

After:

image

@uvtc
Copy link

uvtc commented Jan 31, 2018

Oh my! All of those OS-specific icons have links associated with them, but only the little gray "(i)" ⓘ is clickable! I had no idea. I don't recognize that ⓘ as a link. Maybe it needs to be brighter (not gray) and/or enclosed in a rounded-corner box like the links to the os-specific DMD archives. It definitely should not only show up when hovering.

@uvtc
Copy link

uvtc commented Jan 31, 2018

@bachmeil
Copy link
Contributor

I think it would be better to provide information about the script on the page, because someone new to D is unlikely to investigate the install script further (there's a lot of information on that page). I've been using D for years and didn't know the details of the install script until now. My recommendation is to put this text before the curl command:

The install.sh script is the official D version manager for DMD, GDC and LDC on FreeBSD, Linux and macOS. It provides a convenient way to fetch and install a D compiler without requiring administrative privileges or external dependencies. For more information, see {link to https://dlang.org/install.html}.

@dlang-bot dlang-bot merged commit 744a284 into dlang:master Feb 15, 2018
@wilzbach wilzbach deleted the download-icon-display-always branch July 18, 2018 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants