Issue 18351 - integrate dub changelog with changed.d tool #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilzbach
requested review from
andralex,
CyberShadow and
MartinNowak
as code owners
CyberShadow
reviewed
Feb 2, 2018
posix.mak
Outdated
| @@ -449,7 +450,7 @@ rsync : all kindle pdf | |||
| rsync-only : | |||
| rsync -avzO --chmod=u=rwX,g=rwX,o=rX --delete $(RSYNC_FILTER) $W/ $(REMOTE_DIR)/ | |||
|
|
|||
| dautotest: all verbatim pdf diffable-intermediaries | |||
| dautotest: all verbatim pdf diffable-intermediaries ${DUB_DIR} | |||
There was a problem hiding this comment.
Is this the right place to add the target? Wouldn't the target that builds the changelog be more suitable?
CyberShadow
approved these changes
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prefers dlang.org for cloning
duband adds it todautotest, s.t. changes to DUB will be visible on the pending changelog.See also: dlang/tools#302