Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for require function to associative arrays #2343

Merged
merged 5 commits into from
Jun 21, 2018

Conversation

GilesBathgate
Copy link
Contributor

Documentation for dlang/druntime#2162

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @GilesBathgate! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@GilesBathgate GilesBathgate changed the title Add documentation for getOrAdd function to associative arrays Add documentation for require function to associative arrays Apr 19, 2018
@GilesBathgate GilesBathgate force-pushed the getOrAdd branch 2 times, most recently from 252f860 to 9020eca Compare April 20, 2018 23:08
@GilesBathgate GilesBathgate force-pushed the getOrAdd branch 2 times, most recently from 421f748 to b5669fb Compare May 20, 2018 19:35
@JinShil
Copy link
Contributor

JinShil commented Jun 5, 2018

I recommend that the documentation for both of these functions mentions the fact that they avoid the need for multiple lookups. IMO, that will often be the deciding factor when a user chooses to use these functions.

@JinShil JinShil merged commit f2968d7 into dlang:master Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants