Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 19374 - TypeVector undefined in grammar #2514

Merged
merged 1 commit into from Nov 20, 2018
Merged

fix issue 19374 - TypeVector undefined in grammar #2514

merged 1 commit into from Nov 20, 2018

Conversation

ghost
Copy link

@ghost ghost commented Nov 20, 2018

No description provided.

@ghost ghost requested review from andralex and WalterBright as code owners November 20, 2018 15:37
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @bbasile! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19374 minor TypeVector undefined in grammar

Copy link
Member

@rainers rainers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
While the link for TypeVector jumped into the name mangling grammar before, the latter now jumps back to the added rule. Can this be disambiguated?
Maybe the mangling grammar should not be on this page to begin with.

@ghost
Copy link
Author

ghost commented Nov 20, 2018

Done, renamed the rule "Vector".

@dlang-bot dlang-bot merged commit db18006 into dlang:master Nov 20, 2018
@ghost ghost deleted the issue-19374 branch November 20, 2018 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants