Function Default Parameters are underspecified #2607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
|
|
The commit message shouldn't say that this fixes issue 19645. DMD has to implement the new spec before the issue can be closed. |
aG0aep6G
reviewed
Mar 20, 2019
| function declaration. | ||
| If the default value for a parameter is given, all following | ||
| --- |
There was a problem hiding this comment.
Close the paragraph before starting a code section. HTML doesn't like <pre> in <p>.
WalterBright
force-pushed
the
default-args
branch
from
68f4768 to
9100e8d
Compare
WalterBright
changed the title
|
@WalterBright you need to change the commit message, thats what the bot looks for. |
thewilsonator
approved these changes
Mar 21, 2019
andralex
approved these changes
Mar 21, 2019
|
@andralex, you've merged it with the bad commit message. I've cleaned up after you and reopened the issue. |
|
@aG0aep6G Thanks! |
|
@aG0aep6G sorry, I assumed it'd been fixed already. Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default arguments were incompletely specified.