Improve order of evaluation spec, add lifetime of temporaries spec #2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @andralex! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
dgileadi
reviewed
Apr 12, 2019
|
|
|
@thewilsonator found and fixed one missing paren |
thewilsonator
approved these changes
Apr 12, 2019
thewilsonator
added
the
72h no objection -> merge
|
Waiting to see input from Timon. (N.B the 72->h merge does not auto-merge) |
WalterBright
previously requested changes
Apr 13, 2019
Fixed, thanks
spec/expression.dd
Outdated
| int f4() { writeln("f4() called"); return 1; } | ||
| int f3(int x) { writeln("f3() called"); return x + 1; } | ||
| int f1() { writeln("f1() called"); return 2; } | ||
| int f2() { writeln("f2() called"); return 3; } |
There was a problem hiding this comment.
Please declare them in order. Also, f4 should return 4, not 1. Etc. By scrambling the order and relationships, it leads the reader to look for something tricky going on, when there isn't.
|
Please make sure the commits are squashed when merging. |
andralex
added
auto-merge-squash
and removed
72h no objection -> merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This formalizes behavior already existing in the compiler. It simplifies the rvalue ref DIP.