Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 20500 - always pass -unittest and --DRT-testmode=run-main #2739

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

wilzbach
Copy link
Member

@wilzbach wilzbach commented Jan 23, 2020

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Auto-close Bugzilla Severity Description
20500 major running examples on the home page only displays '1 unittests passed'

@wilzbach
Copy link
Member Author

Both changes are deployed now:

image

It can also be tested live.
Phobos: http://dtest.dlang.io/artifact/website-bd697944980567f6a4ca6682b542d0cbf1902dba-cc4d855be14f0c9d86e509c0341e91ee/web/phobos-prerelease/std_algorithm_setops.html
dlang.org: http://dtest.dlang.io/artifact/website-bd697944980567f6a4ca6682b542d0cbf1902dba-cc4d855be14f0c9d86e509c0341e91ee/web/index.html
http://dtest.dlang.io/artifact/website-bd697944980567f6a4ca6682b542d0cbf1902dba-cc4d855be14f0c9d86e509c0341e91ee/web/spec/function.html

Though to be fair I don't think -unittest is used often (at all?), so just removing it might have been an option as well. OTOH we now support runtime arguments and this is probably the more intuitive behavior, so we might as well support this.

@dlang-bot dlang-bot merged commit f3d2bf3 into dlang:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants