-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor English improvements + notes below #2747
Conversation
|
Thanks for your pull request and interest in making D better, @mark-summerfield! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
|
I still think use of "Aka" is poor practice. It is an abbreviation and not necessarily well known to non-native English speakers. |
The correct syntax is:
That's a very valid point. Although CTFE should allow us to convert from one another, easing the pain, it is not a good default. Could you raise an issue about it ?
Yes, or "Ignore everything after this token".
Looks like it's an error, yes. The correct string would be "foo\bar", but I think "foo/bar.d" would be more adequate, or even "pkg/mod.d". |
|
And thanks for your work! |
|
Hmm, that still seems to fail. Maybe take that out and verify that is the case of the problem and do it in another PR? |
|
Optimistically adding auto-merge |
|
Hmm it failed, but not for the same reason: I'm not sure where that failed. @CyberShadow any guesses? |
|
Something seems to have caused the host compiler to terminate while building the master compiler. I don't know what or why. Unless master is broken (which it doesn't seem to be), it is most likely a random failure (due to PID reuse or something of a similar nature). Should go away on a retry (rebase/amend and force-push). |
1. I've replaced "Aka" with "alias". If that's not wanted I still think "Aka" is wrong and should be replaced by something else. 2. On lines 549-550 it says you can write a named character entity like this: `\name`. But I tried doing: `auto x = "\euro";` and it gave an error. 3. It is a real pity that `__DATE__` uses a US-specific format rather than the universal ISO8601. I hope an `__ISODATE__` and an `__ISOTIMESTAMP__` are added to repair this. 4. I don't know what the explanation for `__EOF__` means. Would "Tells the scanner to stop at this point in the source." be a correct alternative? 5. This page's very last example has the string `"foo\bar"`. Shouldn't this be `r"foo\bar"` or `"foo\\bar"`? And if not, a reason ought to be given.
|
Rebased on master, squashed the commits together, and removed a trailing whitespace on L361 of |
\name. But I tried doing:auto x = "\euro";and it gave an error.__DATE__uses a US-specific format rather than the universal ISO8601. I hope an__ISODATE__and an__ISOTIMESTAMP__are added to repair this.__EOF__means. Would "Tells the scanner to stop at this point in the source." be a correct alternative?"foo\bar". Shouldn't this ber"foo\bar"or"foo\\bar"? And if not, a reason ought to be given.