Links fixes #28
Merged
Links fixes #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also @WalterBright could add to his std.ddoc file two macros used in Phobos: |
|
Am I right that |
Merged
This partially reverts commit 48c5fb8.
Following macros definitions removed: WEB (except phobos-like definitions in index.dd, intro-to-datetime.dd, todo.dd, glossary.dd) EBOOK WEBURL Following macros definitions added: DDLINK - link to other *.dd file (other page on the site, other section in ebook) DDSUBLINK - same as DDLINK, but references to subsection DPLLINK - link to d-programming-language.org page (external link in ebook) NOT_EBOOK - hides its arguments in ebook NOT_EBOOK macro used in spec.dd instead of WEB
All strings replaced:
"$(LINK2 $(WEBURL)" to "$(DPLLINK "
All expressions replaced (using Visual Studio regex for which "@" is the lazy version of "*"):
"\$\(LINK2 \$\(WEB {.@}\.html\)\$\(EBOOK \#{.@}\)\, {.@}\)" to "$(DDLINK \1, \2, \3)"
"\$\(LINK2 \$\(WEB {.@}\.html\)\#{.@}\, {.@}\)" to "$(DDSUBLINK \1, \2, \3)"
dnews removed from win32.mak
|
What are exactly the improvement brought about by this diff? |
|
AFAIK, it fixes a lot of broken links without breaking ebook generation. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WEB(except phobos-like definition in intro-to-datetime.dd and glossary.dd)EBOOKWEBURLDDLINK- link to other *.dd file (other page on the site, other section in ebook)DDSUBLINK- same asDDLINK, but references to subsectionDPLLINK- link to http://d-programming-language.org page (external link in ebook)NOT_EBOOK- hides its arguments in ebook