Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spec wrt. the align attribute #2814

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Fix spec wrt. the align attribute #2814

merged 1 commit into from
Jun 23, 2020

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Jun 5, 2020

The semantics were changed with dlang/dmd#6754.

Resolves https://issues.dlang.org/show_bug.cgi?id=20754.

The semantics were changed with dlang/dmd#6754.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@veelo
Copy link
Contributor

veelo commented Jun 7, 2020

I am in favour of dlang/dmd#6754, but I don’t think the language should be changed silently (https://forum.dlang.org/post/dsklfejzyfmytckeuhby@forum.dlang.org). Since dmd has worked this way for more than three years now I guess one could argue that we have exceeded the deprecation period anyway, but I’m not sure everybody would see it that way. A change log entry would be in order, maybe?

@kinke
Copy link
Contributor Author

kinke commented Jun 7, 2020

A changelog entry for something that was changed/fixed 3 years ago? C'mon. The previous scheme was just plain wrong, resulting in stuff like T.alignof = 4, T.sizeof = 10 etc.

Copy link
Member

@Geod24 Geod24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @kinke , changelog entries are the burden of the PR that changes the behavior, not the ones that document it. If anything, it would be confusing to have it now.

@Geod24 Geod24 merged commit e3aed68 into dlang:master Jun 23, 2020
@kinke kinke deleted the patch-1 branch June 23, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants