Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document issue 21340 - extern(C++, (expression)) now accepts empty tuples #2872

Merged
merged 2 commits into from
Nov 3, 2020

Conversation

thewilsonator
Copy link
Contributor

see also dlang/dmd#11905

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21340 enhancement extern(C++,(emptyTuple)) should result in no namespace not an error

@thewilsonator
Copy link
Contributor Author

@Geod24 ping for spec PR

Copy link
Member

@Geod24 Geod24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight rephrase, oLGTM

spec/cpp_interface.dd Outdated Show resolved Hide resolved
Co-authored-by: Mathias LANG <geod24@gmail.com>
@Geod24 Geod24 changed the title document issue 21340 - extern(C++, (emptyTuple)) Document issue 21340 - extern(C++, (expression)) now accepts empty tuples Nov 3, 2020
@dlang-bot dlang-bot merged commit 80231f5 into dlang:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants