Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 21292: Link directly to https s3 downloads #2933

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Fix 21292: Link directly to https s3 downloads #2933

merged 1 commit into from
Jan 22, 2021

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Jan 22, 2021

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @Geod24!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 21292 major Chrome now blocks downloading .dmg or .exe compiler file by default

wilzbach
wilzbach approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really prefer if we moved to releases to something that's easier to work with, but I guess this is good enough and eases the pains for the time being.

@Geod24
Copy link
Member Author

Geod24 commented Jan 22, 2021

@wilzbach : So do I, but the issue is orthogonal. We currently have users that click on a download link, and get absolutely nothing. Not even a message from Chrome saying "This file couldn't be downloaded because...". It's embarrassing and needs to be fixed yesterday.

@wilzbach wilzbach merged commit 57f2419 into dlang:master Jan 22, 2021
@Geod24 Geod24 deleted the fix-https branch January 22, 2021 19:32
@Geod24
Copy link
Member Author

Geod24 commented Jan 25, 2021

This didn't work, because the files are stored by year internally, not by release...

Geod24
Geod24 commented Jan 25, 2021
View reviewed changes
download.dd
N_DLSITE=http://downloads.dlang.org/nightlies/dmd-master/$0
DLSITE=https://s3.us-west-2.amazonaws.com/downloads.dlang.org/releases/2.x/$(DMDV2)/$0
B_DLSITE=https://s3.us-west-2.amazonaws.com/downloads.dlang.org/pre-releases/2.x/$(B_DMDV2)/$0
N_DLSITE=https://s3.us-west-2.amazonaws.com/downloads.dlang.org/dmd-master/2.x/$0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy pasta error

@Geod24 Geod24 mentioned this pull request Jan 25, 2021
Merged
@MartinNowak MartinNowak mentioned this pull request Feb 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilzbach wilzbach wilzbach approved these changes

@andralex andralex Awaiting requested review from andralex

@CyberShadow CyberShadow Awaiting requested review from CyberShadow CyberShadow is a code owner

@MartinNowak MartinNowak Awaiting requested review from MartinNowak MartinNowak is a code owner

Assignees
No one assigned
Labels
Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Geod24 @dlang-bot @wilzbach