Slightly rephrase and actualize -preview=in section #2937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @Geod24! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
This could probably use a bit more "$(P)" to look better. |
|
|
PetarKirov
reviewed
Feb 7, 2021
spec/function.dd
Outdated
| Dynamic arrays$(COMMA) classes$(COMMA) associative arrays$(COMMA) function pointers$(COMMA) and delegates | ||
| will always be passed by value$(COMMA) to allow for covariance. | ||
| If the type of the parameter does not fall in one of those categories$(COMMA) | ||
| will always be passed by value$(COMMA).) |
There was a problem hiding this comment.
Suggested change
| will always be passed by value$(COMMA).) | |
| will always be passed by value.) |
Also remove other trailing commas, since each paragraph must end with full stop.
| whether or not it is passed by reference is implementation defined$(COMMA) and the backend is free | ||
| to choose the method that will best fit the ABI of the platform. | ||
| $(B Note: This requires the $(D -preview=in) switch$(COMMA) available in v2.094.0 or higher.) | ||
| ) |
There was a problem hiding this comment.
Wrap this paragraph in $(IMPLEMENTATION_DEFINED macro
spec/function.dd
Outdated
| @@ -1282,18 +1282,20 @@ $(H3 $(LNAME2 param-storage, Parameter Storage Classes)) | |||
|
|
|||
| $(H3 $(LNAME2 in-params, In Parameters)) | |||
|
|
|||
| $(B Note: The following requires the $(D -preview=in) switch$(COMMA) available in v2.094.0 or higher. | |||
There was a problem hiding this comment.
v2.094.0 -> add link to https://dlang.org/changelog/2.094.0.html#preview-in
- Adding 'also' to connect it better with the previous sentence about 'const scope'; - Remove 'they' which was grammatically incorrect; - Use parenthesis around 'e.g.', to be consistent with the two previous usages; - Remove 'to allow for covariance, as 'in' are not covariant with const anymore; - Added more `$(P)` for the paragraph too look less beefy; - Make the note about the preview switch more prevalent not to confuse users; - Document the behavior without the preview switch;
@CyberShadow : I think I'm not to blame for this one ? |
|
Fixed |
RazvanN7
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw #2916 and realize it needed some tiny adjustments w.r.t.
-preview=in.