Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec change for Issue 16140 #2977

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Spec change for Issue 16140 #2977

merged 2 commits into from
Mar 10, 2021

Conversation

RazvanN7
Copy link
Contributor

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
16140 enhancement while(auto x = y) does not behave like if(auto x = y)


---
for (; Expression; ) ScopeStatement
---
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have chosen to delete this piece because it would have made this PR more complicated and verbose. To get an idea, I would have had to make a discussion on whether the IfCondition is an expression or not, I would have had to explain the lowering when IfCondition is not expression etc.

@dlang-bot dlang-bot merged commit 157d923 into master Mar 10, 2021
@Geod24
Copy link
Member

Geod24 commented Mar 10, 2021

Can we not merge spec changes before the actual changes ?

@RazvanN7
Copy link
Contributor Author

If you merge dlang/dmd#12246 right away, then this is no longer an issue :P . Just kidding, I was actually wondering what is the policy on this. Should the spec PR be merged when the new version is released or after the PR makes it to master?

@Geod24 Geod24 deleted the RazvanN7-patch-1 branch March 10, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants