-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec change for Issue 16140 #2977
Conversation
|
Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
|
|
|
||
| --- | ||
| for (; Expression; ) ScopeStatement | ||
| --- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have chosen to delete this piece because it would have made this PR more complicated and verbose. To get an idea, I would have had to make a discussion on whether the IfCondition is an expression or not, I would have had to explain the lowering when IfCondition is not expression etc.
|
Can we not merge spec changes before the actual changes ? |
|
If you merge dlang/dmd#12246 right away, then this is no longer an issue :P . Just kidding, I was actually wondering what is the policy on this. Should the spec PR be merged when the new version is released or after the PR makes it to master? |
PR: dlang/dmd#12246