Fix Issue 21161 - [Variadic Templates] uses outdated example from D1 #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geod24
reviewed
May 6, 2021
| @@ -132,16 +132,16 @@ $(H3 The D Look Ma No Templates Solution) | |||
| ------ | |||
| import core.vararg; | |||
| import core.stdc.stdio; | |||
| import std.format; | |||
|
|
|||
| //For reference, this function signature is from D1.0 | |||
There was a problem hiding this comment.
The point of this example is to show a template-less approach. Removing the FQN from doFormat makes sense but mentioning D1 is just confusing IMO. If you really want it mentioned, something like:
"While the standard library favors variadic templates over runtime type information, this approach can be taken whenever variadic templates are not practical, such as when passing a delegate is needed"
There was a problem hiding this comment.
feedback incorporated, thoughts?
maxhaton
force-pushed
the
tango_format_article
branch
from
82b1952 to
63128c6
Compare
Geod24
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.