Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 22825: First newline terminates special token sequences #3234

Merged
merged 1 commit into from Feb 28, 2022
Merged

Issue 22825: First newline terminates special token sequences #3234

merged 1 commit into from Feb 28, 2022

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Feb 28, 2022 •
edited

Clarify in the spec that these special token sequences are terminated by the first EndOfLine seen.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
✗ 22825 normal #line parsing doesn't follow the spec

@ibuclaw ibuclaw mentioned this pull request Feb 28, 2022
Closed
@ibuclaw
Copy link
Member Author

ibuclaw commented Feb 28, 2022

Oops, forgot the closing parens.

@dlang-bot dlang-bot merged commit a85f184 into dlang:master Feb 28, 2022
@ibuclaw ibuclaw deleted the issue22825 branch February 28, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

@andralex andralex Awaiting requested review from andralex andralex is a code owner

@WalterBright WalterBright Awaiting requested review from WalterBright WalterBright is a code owner

@maxhaton maxhaton Awaiting requested review from maxhaton maxhaton is a code owner

@mdparker mdparker Awaiting requested review from mdparker mdparker is a code owner

Assignees
No one assigned
Labels
auto-merge Bug Fix
Projects
None yet
Milestone
No milestone
3 participants
@ibuclaw @dlang-bot @thewilsonator