Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue 23553 - opCmp spec is incomplete #3474

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Fix Issue 23553 - opCmp spec is incomplete #3474

merged 1 commit into from
Dec 16, 2022

Conversation

RazvanN7
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 23553 enhancement opCmp spec is incomplete

RazvanN7
RazvanN7 commented Dec 16, 2022
View reviewed changes
spec/operatoroverloading.dd
assert(!(s < b)); // s.opCmp(b) > 0 - S.opCmp(ref B) is exact match
assert(!(b < s)); // s.opCmp(b) < 0 - S.opCmp(ref B) is exact match
assert(b < cs); // b.opCmp(s) < 0 - B.opCmp(ref const S) is exact match
static assert(!__traits(compiles, b < c)); // both C.opCmp and B.opcmp match exactly
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that, due to a bug, this assert will fail.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it in bugzilla?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://issues.dlang.org/show_bug.cgi?id=21453

@RazvanN7
Copy link
Contributor Author

cc @dkorpel @thewilsonator

@RazvanN7 RazvanN7 merged commit 0f85081 into dlang:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkorpel dkorpel dkorpel approved these changes

@andralex andralex Awaiting requested review from andralex andralex is a code owner

@WalterBright WalterBright Awaiting requested review from WalterBright WalterBright is a code owner

@maxhaton maxhaton Awaiting requested review from maxhaton maxhaton is a code owner

@mdparker mdparker Awaiting requested review from mdparker mdparker is a code owner

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RazvanN7 @dlang-bot @dkorpel