Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve constraints article #3487

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Improve constraints article #3487

merged 3 commits into from
Jan 11, 2023

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Jan 9, 2023

Depends on #3486, please merge that first.

Add example of type specializations.
Improve wording.
Add subheadings.
Make some examples compilable.
Add links to IsExpression, CTFE, traits.
Note that a parameter specialization e.g. (T : float) accepts types that implicitly convert to float, and that using a constraint is necessary to prevent accepting an implicitly converting type.
Use const variable templates instead of template.
Make isAddable example runnable & use opBinary.
Explain __traits(compiles) and why using a function literal is useful vs T.init.
Move multiple parameter constraint example up.
Introduce isStack better.
Mention using static if to combine overloads.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Add example of type specializations.
Add subheadings.
Make some examples compilable.
Add links to IsExpression, CTFE, traits.
Note that a parameter e.g. `(T : float)` accepts types that implicitly
convert to float, and that using a constraint is necessary to prevent
accepting an implicitly converting type.
Make isAddable example runnable & use opBinary.
Explain __traits(compiles) and why using a function literal is useful vs
T.init.
Move multiple parameter constraint example up.
Introduce isStack better.
Mention using `static if` to combine overloads.
@ntrel ntrel marked this pull request as ready for review January 9, 2023 16:08
Even with -O, dmd doesn't detect null dereference inside
__traits(compiles) even though it does with runtime code.
@dlang-bot dlang-bot merged commit c8fbb3e into dlang:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants