Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 23636 - No spec docs for shared qualifer #3494

Merged
merged 2 commits into from Jan 18, 2023

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Jan 16, 2023

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23636 enhancement No spec docs for shared qualifer

@anon17
Copy link

anon17 commented Jan 17, 2023

Additions:

Mutable data that is meant to be shared among multiple threads should be declared with the shared qualifier. This prevents unsynchronized reading and writing to the data, which would otherwise cause data races. It's done by differentiating between shared and unshared data, so they can't implicitly substitute each other without a cast, and thus shared data can't be accidentally treated as unshared. The shared type attribute is transitive (like const and immutable).

Lastly, to declare global/static data to be implicitly shared across multiple threads without any compiler checks, see $(DDSUBLINK spec/attribute, gshared, __gshared). Such data has unshared type.

@RazvanN7 RazvanN7 merged commit c0befca into dlang:master Jan 18, 2023
@RazvanN7
Copy link
Contributor

@anon17 feel free to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants